-
Notifications
You must be signed in to change notification settings - Fork 748
Fixup LogRecord.emit signature #4737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanRussell
reviewed
Sep 8, 2025
opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
Marking this draft in favor of #4741 that has more chances to get approved |
18bca18
to
cee1516
Compare
10 tasks
efa7249
to
cf0596c
Compare
aabmass
approved these changes
Sep 30, 2025
DylanRussell
approved these changes
Sep 30, 2025
lzchen
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes Logger.emit interface to make the logrecord optional and add all the expected parameters documented in the spec to build a logrecord and provides two overload interfaces.
From an user point of view nothing changes since the old code will still work.
TODO:
Refs #4319
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: