Skip to content

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Sep 8, 2025

Description

This changes Logger.emit interface to make the logrecord optional and add all the expected parameters documented in the spec to build a logrecord and provides two overload interfaces.

From an user point of view nothing changes since the old code will still work.

TODO:

  • do we lose something with the missing resource in logginghandler, see FIXME
  • add tests for new interface taking the single parameters

Refs #4319

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner September 8, 2025 16:19
@xrmx xrmx mentioned this pull request Sep 9, 2025
11 tasks
@xrmx
Copy link
Contributor Author

xrmx commented Sep 9, 2025

Marking this draft in favor of #4741 that has more chances to get approved

@xrmx xrmx marked this pull request as draft September 9, 2025 16:49
@xrmx xrmx force-pushed the fixup-emit-signature branch from 18bca18 to cee1516 Compare September 15, 2025 12:45
@xrmx xrmx marked this pull request as ready for review September 25, 2025 14:14
@xrmx xrmx force-pushed the fixup-emit-signature branch from efa7249 to cf0596c Compare September 30, 2025 07:51
@xrmx xrmx enabled auto-merge (squash) October 1, 2025 09:11
@xrmx xrmx merged commit da15594 into open-telemetry:main Oct 1, 2025
470 of 471 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants